Extract loader-v2-interface crate #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-loader-instruction
branch
from
70581d4 to
f35686a
Compare
joncinque
reviewed
Jan 22, 2025
sdk/loader-instruction/Cargo.toml
Outdated
| @@ -0,0 +1,31 @@ | |||
| [package] | |||
| name = "solana-loader-instruction" | |||
There was a problem hiding this comment.
nit: can we call this solana-loader-v2-interface? the v2 bit so that people are less tempted to use it, especially when they see v3 and v4, and interface for consistency with the other loader crates, even though there's no state.
I could even be convinced to go with v1 since they share an interface.
sdk/loader-instruction/Cargo.toml
Outdated
|
|
||
| [features] | ||
| bincode = ["dep:solana-instruction", "serde"] | ||
| dev-context-only-utils = ["bincode"] |
kevinheavey
changed the title
|
@yihau can you accept ownership of |
kevinheavey
force-pushed
the
extract-loader-instruction
branch
from
5ffebc6 to
c4bd2c2
Compare
kevinheavey
force-pushed
the
extract-loader-instruction
branch
from
c4bd2c2 to
a30aec7
Compare
joncinque
approved these changes
Jan 22, 2025
|
loader-v2 program management has been deactivated for a while (a year or longer). Why not remove it entirely? |
|
would be a breaking change in solana-program and solana-sdk |
|
Yes, but what about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::loader_instructionimposes asolana_programdep onsolana_transaction_status.Summary of Changes
solana-loader-instructioninstead ofsolana-loader-interfacebecause the instruction module is the only thing in the crate